Skip to content

fix: testing repo access 404 error - #799

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
hudeng-go:patch-12
Aug 5, 2026
Merged

fix: testing repo access 404 error#799
BLumia merged 1 commit into
linuxdeepin:masterfrom
hudeng-go:patch-12

Conversation

@hudeng-go

@hudeng-go hudeng-go commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

testing仓库的dde组件被去掉了,因此在这个里面也去掉。

Summary by Sourcery

Build:

  • Adjust APT testing repository entries in dev docs deployment workflow to drop the deprecated dde component section.

testing仓库的dde组件被去掉了,因此在这个里面也去掉。
@sourcery-ai

sourcery-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

.github workflow is updated to remove the deprecated 'dde' component from the testing repository entries, preventing 404 errors when configuring apt sources during the dev-doc deployment job.

Flow diagram for updated apt sources configuration in deploy-dev-doc workflow

flowchart TD
  A[deploy-dev-doc job starts] --> B[Remove default /etc/apt/sources.list]
  B --> C[Add deepin_Develop_dde repo]
  C --> D[Add deepin_community_testing repo
components: main community commercial]
  D --> E[Add deepin_community_stable repo
components: main community commercial]
  E --> F[Run apt-get update]
  F --> G[Install dependencies]
Loading

File-Level Changes

Change Details Files
Update apt source list configuration in the dev-doc deployment workflow to drop the removed 'dde' component from testing repo entries.
  • Modify binary testing repo entry to list 'unstable main community commercial' components instead of including 'dde'.
  • Modify source testing repo entry similarly to remove the 'dde' component while keeping other components intact.
.github/workflows/deploy-dev-doc.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, hudeng-go

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit 47b097f into linuxdeepin:master Aug 5, 2026
4 of 5 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the same testing repository URL and component list are echoed twice (deb and deb-src), consider extracting these into a shared variable or here-doc snippet to avoid divergence if they need updating again.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the same testing repository URL and component list are echoed twice (deb and deb-src), consider extracting these into a shared variable or here-doc snippet to avoid divergence if they need updating again.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码准确修复了apt源组件配置冲突问题,逻辑严密且无任何副作用
修改精准去除了冗余的dde组件,符合包管理最佳实践,无需扣分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

修改位于.github/workflows/deploy-dev-doc.yml文件的apt源配置部分,将deepin-community/testing源中的dde组件移除。此修正避免了与上方专属的deepin:/Develop:/dde/deepin_develop源发生包版本冲突或优先级混乱,逻辑完全正确。
建议:保持当前的源配置层级划分,确保特定组件仅从其专属OBS源拉取。

  • 2.代码质量(良好)✓

修改意图明确,针对性强,仅调整了必要的组件列表参数,没有引入冗余配置或无意义的代码变更。
建议:可在该步骤上方添加简短的shell注释,说明为何testing源不包含dde组件,以防止后续维护者误加。

  • 3.代码性能(无性能问题)✓

移除dde组件后,apt-get update在解析该源时需要拉取和解析的元数据包列表减少,轻微降低了CI流水线中环境初始化的网络IO与解析时间。
建议:无需优化。

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次diff仅修改了apt源URL中的组件列表字符串,去除了dde字段,未引入任何新的不安全配置或攻击面。未修改部分的安全配置不在本次审查范围内。
建议:维持当前安全基线。

■ 【改进建议代码示例】

              rm /etc/apt/sources.list
              # 优先配置 dde 专属开发源,确保拉取最新开发版 dde 组件
              echo "deb [trusted=yes] https://ci.deepin.com/repo/obs/deepin:/Develop:/dde/deepin_develop/ ./" > /etc/apt/sources.list
              echo "deb-src [trusted=yes] https://ci.deepin.com/repo/obs/deepin:/Develop:/dde/deepin_develop/ ./" >> /etc/apt/sources.list
              # 配置社区测试源,排除 dde 组件以避免与上方专属源产生版本冲突
              echo "deb [trusted=yes] https://ci.deepin.com/repo/deepin/deepin-community/testing/ unstable main community commercial" >> /etc/apt/sources.list
              echo "deb-src [trusted=yes] https://ci.deepin.com/repo/deepin/deepin-community/testing/ unstable main community commercial" >> /etc/apt/sources.list
              echo "deb [trusted=yes] https://ci.deepin.com/repo/deepin/deepin-community/stable/ beige main community commercial" >> /etc/apt/sources.list
              echo "deb-src [trusted=yes] https://ci.deepin.com/repo/deepin/deepin-community/stable/ beige main community commercial" >> /etc/apt/sources.list
              apt-get update && apt-get install -y --force-yes ca-certificates apt-transport-https sudo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants